Skip to content

Refactor NodeStack and NodePath #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

Refactor NodeStack and NodePath #275

merged 1 commit into from
Nov 4, 2024

Conversation

@lorisleiva
Copy link
Member

@lorisleiva lorisleiva commented Nov 1, 2024 •
edited
Loading

This PR adds new NodePath helper functions and pushes some of the responsibilities from the NodeStack to the NodePath. The former is designed to be a mutable stack that updates as we traverse the tree, whereas the latter is designed to hold an immutable path of nodes finishing in a specific typed node.

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 07df737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Nov 1, 2024
Merged
Merged
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Nov 1, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lorisleiva and the rest of your teammates on Graphite Graphite

This was referenced Nov 1, 2024
Merged
Merged
@lorisleiva lorisleiva force-pushed the loris/refactor-node-path-and-node-stack branch from 61ceaa8 to 29f2c45 Compare November 1, 2024 11:34
This was referenced Nov 4, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@lorisleiva lorisleiva force-pushed the loris/use-node-path-in-renderers-js branch from 449b176 to 2702bbe Compare November 4, 2024 11:12
@lorisleiva lorisleiva force-pushed the loris/refactor-node-path-and-node-stack branch from 29f2c45 to 4cc0374 Compare November 4, 2024 11:12
@lorisleiva lorisleiva mentioned this pull request Nov 4, 2024
Merged
@lorisleiva lorisleiva marked this pull request as ready for review November 4, 2024 12:19
@lorisleiva Graphite App
Copy link
Member Author

lorisleiva commented Nov 4, 2024 •
edited
Loading

Merge activity

  • Nov 4, 8:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 9:00 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 4, 9:01 AM EST: A user merged this pull request with Graphite.

@lorisleiva lorisleiva changed the base branch from loris/use-node-path-in-renderers-js to graphite-base/275 November 4, 2024 13:53
@lorisleiva lorisleiva changed the base branch from graphite-base/275 to main November 4, 2024 13:56
@lorisleiva lorisleiva force-pushed the loris/refactor-node-path-and-node-stack branch from 4cc0374 to 07df737 Compare November 4, 2024 13:59
@lorisleiva lorisleiva merged commit 35dec6a into main Nov 4, 2024
2 checks passed
@lorisleiva lorisleiva deleted the loris/refactor-node-path-and-node-stack branch November 4, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lorisleiva